From d0b691df0ee74863ca54ca697aa4d4212cf401a7 Mon Sep 17 00:00:00 2001 From: alex-ong Date: Sat, 26 Jan 2019 17:03:46 +1100 Subject: DO NOT USE - debounce successfully compiled. --- quantum/debounce.h | 25 ++++++++++++++++++++----- 1 file changed, 20 insertions(+), 5 deletions(-) (limited to 'quantum/debounce.h') diff --git a/quantum/debounce.h b/quantum/debounce.h index 360af77e78..7fe2d693d1 100644 --- a/quantum/debounce.h +++ b/quantum/debounce.h @@ -1,11 +1,26 @@ #pragma once +/* +Copyright 2017 Alex Ong +This program is free software: you can redistribute it and/or modify +it under the terms of the GNU General Public License as published by +the Free Software Foundation, either version 2 of the License, or +(at your option) any later version. +This program is distributed in the hope that it will be useful, +but WITHOUT ANY WARRANTY; without even the implied warranty of +MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +GNU General Public License for more details. +You should have received a copy of the GNU General Public License +along with this program. If not, see . +*/ + + +#include "matrix.h" + +void debounce_init(void); //every debounce algorithm will have unique storage needs. // raw is the current key state -// on entry cooked is the previous debounced state -// on exit cooked is the current debounced state +// cooked is the debounced input/output key state // changed is true if raw has changed since the last call -void debounce(matrix_row_t raw[], matrix_row_t cooked[], uint8_t num_rows, bool changed); +void debounce(matrix_row_t raw[], matrix_row_t cooked[], bool changed); bool debounce_active(void); - -void debounce_init(uint8_t num_rows); \ No newline at end of file -- cgit v1.2.3 From 123608fb318a42500d64d29aa46c7d08140033fd Mon Sep 17 00:00:00 2001 From: alex-ong Date: Sat, 26 Jan 2019 17:10:27 +1100 Subject: DO NOT USE Revert back to original API to support split_keyboards. --- quantum/debounce.h | 4 ++-- quantum/debounce/debounce_sym_g.c | 8 ++++---- quantum/matrix.c | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) (limited to 'quantum/debounce.h') diff --git a/quantum/debounce.h b/quantum/debounce.h index 7fe2d693d1..34b952ee72 100644 --- a/quantum/debounce.h +++ b/quantum/debounce.h @@ -16,11 +16,11 @@ along with this program. If not, see . #include "matrix.h" -void debounce_init(void); //every debounce algorithm will have unique storage needs. +void debounce_init(uint8_t num_rows); //every debounce algorithm will have unique storage needs. // raw is the current key state // cooked is the debounced input/output key state // changed is true if raw has changed since the last call -void debounce(matrix_row_t raw[], matrix_row_t cooked[], bool changed); +void debounce(matrix_row_t raw[], matrix_row_t cooked[], uint8_t num_rows, bool changed); bool debounce_active(void); diff --git a/quantum/debounce/debounce_sym_g.c b/quantum/debounce/debounce_sym_g.c index c206f28647..4a6996c73d 100644 --- a/quantum/debounce/debounce_sym_g.c +++ b/quantum/debounce/debounce_sym_g.c @@ -26,10 +26,10 @@ When no state changes have occured for DEBOUNCE milliseconds, we push the state. static bool debouncing = false; static uint16_t debouncing_time; -void debounce_init(void) {} +void debounce_init(uint8_t num_rows) {} #if DEBOUNCE > 0 -void debounce(matrix_row_t raw[], matrix_row_t cooked[], bool changed) +void debounce(matrix_row_t raw[], matrix_row_t cooked[], uint8_t num_rows, bool changed) { if (changed) { debouncing = true; @@ -37,14 +37,14 @@ void debounce(matrix_row_t raw[], matrix_row_t cooked[], bool changed) } if (debouncing && timer_elapsed(debouncing_time) > DEBOUNCE) { - for (int i = 0; i < MATRIX_ROWS; i++) { + for (int i = 0; i < num_rows; i++) { cooked[i] = raw[i]; } debouncing = false; } } #else //no debouncing. -void debounce(matrix_row_t raw[], matrix_row_t cooked[], bool changed) +void debounce(matrix_row_t raw[], matrix_row_t cooked[], uint8_t num_rows, bool changed) { for (int i = 0; i < MATRIX_ROWS; i++) { cooked[i] = raw[i]; diff --git a/quantum/matrix.c b/quantum/matrix.c index 8fc4175bde..5b7a0e03b1 100644 --- a/quantum/matrix.c +++ b/quantum/matrix.c @@ -122,7 +122,7 @@ void matrix_init(void) { raw_matrix[i] = 0; matrix[i] = 0; } - debounce_init(); + debounce_init(MATRIX_ROWS); matrix_init_quantum(); } @@ -143,7 +143,7 @@ uint8_t matrix_scan(void) } #endif - debounce(raw_matrix, matrix, changed); + debounce(raw_matrix, matrix, MATRIX_ROWS, changed); matrix_scan_quantum(); return 1; -- cgit v1.2.3 From 5b7fc758d7b0d0ef24bc2861c4b2ba6708fbd367 Mon Sep 17 00:00:00 2001 From: alex-ong Date: Sat, 26 Jan 2019 17:46:27 +1100 Subject: Restored debounce.h since there wasnt any real change. --- quantum/debounce.h | 21 ++++----------------- 1 file changed, 4 insertions(+), 17 deletions(-) (limited to 'quantum/debounce.h') diff --git a/quantum/debounce.h b/quantum/debounce.h index 34b952ee72..8397823ebb 100644 --- a/quantum/debounce.h +++ b/quantum/debounce.h @@ -1,26 +1,13 @@ #pragma once -/* -Copyright 2017 Alex Ong -This program is free software: you can redistribute it and/or modify -it under the terms of the GNU General Public License as published by -the Free Software Foundation, either version 2 of the License, or -(at your option) any later version. -This program is distributed in the hope that it will be useful, -but WITHOUT ANY WARRANTY; without even the implied warranty of -MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -GNU General Public License for more details. -You should have received a copy of the GNU General Public License -along with this program. If not, see . -*/ - #include "matrix.h" -void debounce_init(uint8_t num_rows); //every debounce algorithm will have unique storage needs. - // raw is the current key state -// cooked is the debounced input/output key state +// on entry cooked is the previous debounced state +// on exit cooked is the current debounced state // changed is true if raw has changed since the last call void debounce(matrix_row_t raw[], matrix_row_t cooked[], uint8_t num_rows, bool changed); bool debounce_active(void); + +void debounce_init(uint8_t num_rows); -- cgit v1.2.3 From b5b119544a4e943b3eb56f6a32f350c428f532f7 Mon Sep 17 00:00:00 2001 From: Alex Ong Date: Sat, 26 Jan 2019 22:44:33 +1100 Subject: Removed #include "matrix.h" from debounce.h --- quantum/debounce.h | 2 -- 1 file changed, 2 deletions(-) (limited to 'quantum/debounce.h') diff --git a/quantum/debounce.h b/quantum/debounce.h index 8397823ebb..9ca05c6824 100644 --- a/quantum/debounce.h +++ b/quantum/debounce.h @@ -1,7 +1,5 @@ #pragma once -#include "matrix.h" - // raw is the current key state // on entry cooked is the previous debounced state // on exit cooked is the current debounced state -- cgit v1.2.3